Exit device-module-test early if we detect other running netlab instances#3606
Draft
snuffy22 wants to merge 4 commits into
Draft
Exit device-module-test early if we detect other running netlab instances#3606snuffy22 wants to merge 4 commits into
snuffy22 wants to merge 4 commits into
Conversation
Contributor
Author
|
@ipspace maybe i'm solving this in the wrong place.. |
Contributor
Author
|
mm But one thing I did notice, the running of This is without my patch.. My running default lab, before trying
|
ipspace
requested changes
Jul 11, 2026
ipspace
left a comment
Owner
There was a problem hiding this comment.
Two major changes:
- Don't run a subprocess. Use the
utils.status.read_statusfunction - Don't assume you have to check the default instance. I'm using the
multilabplugin, so the integration tests don't interfere with other stuff I'm doing. That instance needs to be checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a early escape when trying to run tests and you have another 'default' netlab lab already running.
Mentioned in #3604
Conditional that it only cares if user is trying to run the
upcase where it would clash with an existing lab.