Draft feature: Add multi-topology file merge support#3592
Draft
jbemmel wants to merge 5 commits into
Draft
Conversation
Allow netlab create and related commands to accept multiple topology files that are merged into a single lab definition, with plain-string messages concatenated across files. Includes GRE integration test split into underlay and overlay topologies. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply http_fetch_content to every URL argument when netlab create is invoked with multiple topology files, using numbered download filenames when more than one URL is provided. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the topology/input merge fixtures and unit test; multi-topology coverage remains in the integration test directory. Co-authored-by: Cursor <cursoragent@cursor.com>
Simplify merge_topology by only merging dicts and lists when both sides have matching types, otherwise falling through to overlay replacement. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove underlay/overlay directory handling from the integration test harness; multi-topology labs can be created manually with multiple files. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow netlab create and related commands to accept multiple topology files that are merged into a single lab definition.
Includes an example GRE integration test split into underlay and overlay topologies.
Context: #3588