Add 'netlab_start_exec' clab group variable #3047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to 'netlab_config_exec' variable, this variable contains a list of commands that are appended to the node 'clab.exec' list. Its current use case is the initial delay (implemented with 'sleep' command) when starting Dell OS10 containers.
There was a problem hiding this comment.
Pull request overview
This PR adds infrastructure support for a new netlab_start_exec group variable that allows adding commands to the containerlab clab.exec list. The primary use case is to add initial delays for containers like Dell OS10 that need extra time to start before configuration can proceed.
Changes:
- Refactored duplicate code into a new
add_clab_exec()helper function that generalizes adding exec commands from group variables - Added call to
add_clab_exec()withnetlab_start_execin thenode_post_transformmethod to support start-time exec commands - Updated
add_default_config_mode()to use the new helper function fornetlab_config_exec
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to 'netlab_config_exec' variable, this variable contains a list of commands that are appended to the node 'clab.exec' list.
Its current use case is the initial delay (implemented with 'sleep' command) when starting Dell OS10 containers.