feature(console): password confirmation when creating encrypted archive#90
Open
powerjungle wants to merge 1 commit intoip7z:mainfrom
Open
feature(console): password confirmation when creating encrypted archive#90powerjungle wants to merge 1 commit intoip7z:mainfrom
powerjungle wants to merge 1 commit intoip7z:mainfrom
Conversation
powerjungle
force-pushed
the
feat/encr-archive-pass-confirm
branch
4 times, most recently
from
711b591 to
ab340a5
Compare
So that typos become less likely in the password.
powerjungle
force-pushed
the
feat/encr-archive-pass-confirm
branch
from
ab340a5 to
98975d9
Compare
gyurix
reviewed
Apr 16, 2026
gyurix
left a comment
gyurix
left a comment
There was a problem hiding this comment.
Feature is useful and scope is reasonably contained.
Main gap: password mismatch currently fails whole operation instead of re-prompting, and there is no visible coverage for EOF/cancel/mismatch cases. For a typo-prevention feature, immediate hard-fail is rough UX.
Merge readiness: 7/10. Before merge: re-prompt on mismatch, add a couple console-input regression cases, and keep prompt text consistent with no-echo variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that typos become less likely in the password.
Closes: #86