Conversation
gyurix
left a comment
There was a problem hiding this comment.
Idea is useful, but patch does not match existing mac target conventions.
Current files use gcc/g++, warn_gcc.mak, and O=b/g, while existing mac targets in-tree use clang + warn_clang_mac.mak + O=b/m_$(PLATFORM). This looks copy-pasted from non-mac configs instead of aligned with current mac build setup.
Merge readiness: 4/10. Before merge: match existing mac toolchain conventions, show successful builds for both ppc and ppc64, and explain expected ASM/toolchain support.
|
Configs are inconsistent here (gcc conventions contradict mac conventions), but since the choice is non-functional, I used a simpler one. I will change that to match clang config in that part. |
|
@gyurix I have updated the PR to use
You will need either native hardware or a set-up with 10.5/10.6 with Rosetta to run these, but binaries are available here:
MacPorts uses the latest gcc which is set as the primary one (MacPorts-wide), since portfile excludes old compilers: |
I have confirmed that the executable works.