Open
Conversation
Author
|
Hi, are you interested in this patch? If not I can remove... |
gyurix
reviewed
Apr 16, 2026
gyurix
left a comment
gyurix
left a comment
There was a problem hiding this comment.
Reasonable bug report, patch is too blunt.
#if defined(TIME_UTC) && !defined(__ANDROID__) fixes one Android toolchain case by disabling timespec_get() on all Android targets. That can become wrong again as NDK/API availability changes.
Merge readiness: 5/10. Before merge: gate on actual function availability / API level instead of platform-wide __ANDROID__, or at least document tested Android NDK range.
Author
|
After some serach it seems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android NDK define TIME_UTC but doesn't have the timespec_get() function than the compilation fails. This patch add a flag to check if the compilation is on Android.