Replace wasm-opt in bindings dep with local version#283
Open
wulfraem wants to merge 2 commits into
Open
Conversation
- replaced with local installation instructions - see also [related PR](iotaledger/identity#1823)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
PR removes outdated
wasm-optinstalled via NPM, and add the requirement to havewasm-optinstalled locally, which allows using newer versions, that are compatible with the latest Rust toolchain versions.This updates the
wasm-optused in the build process to its latest version.In related projects, we had an error related to newer Rust versions and outdated
wasm-optversion ([parse exception: invalid code after misc prefix: 17 (at ...)]) thrown during build, which was fixed by the same changes. The error does not seem to be thrown at the moment (checked in CI), but possibly will have been with future changes in the code. Using an up-to-datewasm-optversion should prevent this.Links to any relevant issues
See related issue.
Type of change
How the change has been tested
Same changes fixed
wasm-opterror in identity project (see related issue above).Change checklist