feat: accept volume performance classes as disk types#145
Draft
mimihalescu wants to merge 1 commit into
Draft
Conversation
Allow ESSENTIAL, BALANCED and PERFORMANCE as disk types. These were rejected by the additional-disks validation. Update the flag help, docs and tests accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows the new volume performance classes
ESSENTIAL,BALANCEDandPERFORMANCEas disk types. The additional-disks validation previously rejected them; the primaryionoscloud-disk-typealready passed through. Updates flag help, docs and tests.Draft until the classes are live on the API.