feat(select): set modal interface cancel button to "Ok" by default#31197
Open
thetaPC wants to merge 4 commits into
Open
feat(select): set modal interface cancel button to "Ok" by default#31197thetaPC wants to merge 4 commits into
thetaPC wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
requested changes
Jun 8, 2026
| /** | ||
| * The text to display on the cancel button. | ||
| * Defaults to `'Cancel'` for the `alert` and `action-sheet` | ||
| * interfaces, and `'Okay'` for the `modal` interface. |
Member
There was a problem hiding this comment.
Suggested change
| * interfaces, and `'Okay'` for the `modal` interface. | |
| * interfaces, and `'Ok'` for the `modal` interface. |
| /** | ||
| * Resolves the cancel button text, falling back to the | ||
| * per-interface default when `cancelText` is not set: | ||
| * `'Okay'` for the `modal` interface, `'Cancel'` otherwise. |
Member
There was a problem hiding this comment.
Suggested change
| * `'Okay'` for the `modal` interface, `'Cancel'` otherwise. | |
| * `'Ok'` for the `modal` interface, `'Cancel'` otherwise. |
brandyscarney
changed the title
Co-Authored-By: brandyscarney <brandyscarney@users.noreply.github.com>
thetaPC
force-pushed
the
select-modal-cancel
branch
from
d78fb0e to
1461dcf
Compare
github-actions
Bot
added
package: angular
github-actions
Bot
removed
package: angular
thetaPC
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
The select modal commits each option the moment it's tapped, so there's nothing to cancel. A "Cancel" button is misleading because it implies the selection can be undone, when in fact the change has already taken effect. The button should use wording that reflects that it simply closes the modal.
What is the new behavior?
Does this introduce a breaking change?
Other information
Preview