feat(menu-toggle): migrate to Modular Ionic#31171
Draft
thetaPC wants to merge 4 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
thetaPC
commented
May 27, 2026
Comment on lines
+45
to
+49
| try { | ||
| this.visible = await updateVisibility(this.menu); | ||
| } catch { | ||
| this.visible = false; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
connectedCallback and the @Listen handlers discard the Promise returned by visibilityChanged(), so any rejection would surface as unhandled. The current chain can't reject, but catching here makes the method safe against future changes to menuController.get() (from @utils/menu-controller) or ion-menu's isActive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
ion-menu-toggledoes not fragment styles based on themes. All 3 themes share one style. However, it's not configured to the Modular Ionic.What is the new behavior?
themeprop has been removed. Theiosandmdclasses are no longer applied to theion-menu-toggleelement.Does this introduce a breaking change?
This PR introduces breaking changes to how
ion-menu-toggleis styled.Migration Path:
ion-menu-toggle.md,ion-menu-toggle.ios.Other information
Previews