-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(spinner): add recipe and tokens #31014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ionic-modular
Are you sure you want to change the base?
Changes from all commits
0a3f41d
5eee3a8
75a325a
53d06e1
78cfbba
edb0414
2ffac3e
3d89f21
363cddf
7b13706
b2a301a
5f0020c
1179d40
4f5ee31
2cd0043
4c1c6d2
ee53528
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,78 @@ | ||||||
| export interface SpinnerTemplates { | ||||||
| [spinnerName: string]: SpinnerTemplate; | ||||||
| } | ||||||
|
|
||||||
| export interface SpinnerTemplate { | ||||||
| dur: number; | ||||||
| circles?: number; | ||||||
| lines?: number; | ||||||
| elmDuration?: boolean; | ||||||
| fn: (dur: number, index: number, total: number) => SpinnerData; | ||||||
| } | ||||||
|
|
||||||
| interface SpinnerData { | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||
| r?: number; | ||||||
| y1?: number; | ||||||
| y2?: number; | ||||||
| cx?: number; | ||||||
| cy?: number; | ||||||
| style: { [key: string]: string | undefined }; | ||||||
| viewBox?: string; | ||||||
| transform?: string; | ||||||
| } | ||||||
|
|
||||||
| export type IonSpinnerRecipe = { | ||||||
| color?: string; | ||||||
|
|
||||||
| lines?: { | ||||||
| stroke?: { | ||||||
| width?: string; | ||||||
| }; | ||||||
|
|
||||||
| small?: { | ||||||
| stroke?: { | ||||||
| width?: string; | ||||||
| }; | ||||||
| }; | ||||||
|
|
||||||
| sharp?: { | ||||||
| stroke?: { | ||||||
| width?: string; | ||||||
| }; | ||||||
|
|
||||||
| small?: { | ||||||
| stroke?: { | ||||||
| width?: string; | ||||||
| }; | ||||||
| }; | ||||||
| }; | ||||||
| }; | ||||||
|
|
||||||
| circular?: { | ||||||
| stroke?: { | ||||||
| width?: string; | ||||||
| }; | ||||||
| }; | ||||||
|
|
||||||
| crescent?: { | ||||||
| stroke?: { | ||||||
| width?: string; | ||||||
| }; | ||||||
| }; | ||||||
|
|
||||||
| // Sizes | ||||||
| size?: { | ||||||
| [K in SpinnerSize]?: IonSpinnerSizeDefinition; | ||||||
| }; | ||||||
| }; | ||||||
|
|
||||||
| type IonSpinnerSizeDefinition = { | ||||||
| width?: string; | ||||||
| height?: string; | ||||||
| }; | ||||||
|
|
||||||
| export type IonSpinnerConfig = { | ||||||
| size?: SpinnerSize; | ||||||
| }; | ||||||
|
|
||||||
| export type SpinnerSize = 'xsmall' | 'small' | 'medium' | 'large' | 'xlarge'; | ||||||
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description says:
But we still have this variable, why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we discussed that it would be revisited as we add more components. Should I just remove them?