Merged
Conversation
Issue number: resolves #30735 --------- ## What is the current behavior? Toast's wrapper and content divs do not have part attributes. ## What is the new behavior? - Adds `wrapper` and `content` parts to Toast. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information This PR was originally opened by @Hurubon here in #30737. It was lost in `feature-8.8` due to a bad merge, so this PR is to re-apply this feature so it can go out in 8.8.1 (it was originally supposed to go out in 8.8.0) Co-authored-by: Hurubon <58346722+Hurubon@users.noreply.github.com> Co-authored-by: Hurubon <58346722+Hurubon@users.noreply.github.com>
Issue number: resolves internal --------- ## What is the current behavior? When an accordion item was set as disabled, it was still possible to focus using keyboard navigation. ## What is the new behavior? When an accordion item is disabled, `tabindex` is set as -1 to stop being focusable using the keyboard navigation. ## Does this introduce a breaking change? - [ ] Yes - [ ] No ## Other information [preview](https://ionic-framework-qznd9tqne-ionic1.vercel.app/src/components/accordion-group/test/states/) --------- Co-authored-by: Maria Hutt <maria.hutt@outsystems.com>
Issue number: internal --------- ## What is the current behavior? Currently, the 8.8 refresher events are not exported to Angular ## What is the new behavior? With this change, we export the new events and also add Angular tests to validate that they work and will continue working in the future. ## Does this introduce a breaking change? - [ ] Yes - [X] No
github-actions
bot
added
package: core
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8.8.1