fix: make 'android-lang' optional, with java as default

[OS-pedrogustavobilro]

Description

This PR updates the recently added 'android-lang' to be optional, and never be prompted. The default (if no 'android-lang' is provided) was made to be Java. If users want kotlin, they'll have to explicitly set the argument when running the command.

This could be considered a breaking change, but since we're in 0.x version numbers, we're more lenient with breaking changes.

Also fixed a minor bug where when using 'kt' for 'android-lang', the java source directory was not getting removed.

Change Type

• Fix
• Feature
• Refactor
• Breaking Change
• Documentation

Rationale / Problems Fixed

We had released a version where Android Language was always prompted, and the option selected by default was kotlin. Some time after the team had some internal discussions, and decided that we should stick to Java, since it is the Android Language that Capacitor framework is built on, and we may switch the default to Kotlin in the future whenever we migrate Capacitor to use Kotlin.

Having a default made it less relevant for the Android Language option to be prompted, so we removed it in order to have one less prompt option for the command. The plan will be as well to update the capacitor-docs to better let users know of this option, improving discoverability.

Tests or Reproductions

If you want, you may pull the branch, build it, and run it with different 'android-lang' values (and also with no value), and see that you are never prompted for the Android Language

Platforms Affected

• Android
• iOS
• Web

[jcesarmobile]

if kt is also a valid value, should be documented, or if not, it should not accept kt

[OS-pedrogustavobilro]

Hmm, currently in 0.21.0 kt is valid as a shorthand for kotlin, but it wasn't documented. Then during this PR I saw there was an issue and had to add additional logic for it. Butkt doesn't add much, it was just not to type 4 extra characters 😅

So now I feel more inclined to drop it, but it is a breaking change technically, but since we're on 0.x versions, it's more acceptable.

Are you ok with removing kt with that said @jcesarmobile ?

[jcesarmobile]

Whatever you prefer.

Breaking changes are not a big concern for this package since it's a tool and also it's on 0.x as you said.
Adding kotlin support was also a breaking change since it required an extra param.

[OS-pedrogustavobilro]

Ended up removing the 'kt' option.

[jcesarmobile]

Suggested change

	if (option === 'android-lang' && value !== undefined && value !== '') {
	if (option === 'android-lang') {

at this point it can't be undefined or empty, so no need to check

[jcesarmobile]

it's not really optional since if not defined it will be set to java.

If you not make it optional here, you can avoid setting java as default in several places in src/template.ts

[OS-pedrogustavobilro]

Yeah true, I was tinkering with it in an earlier version of the PR, but yeah this shouldn't be optional.

Well spotted!