Skip to content

refactor: make implementation param/return non optional #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jcesarmobile wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: make implementation param/return non optional #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/plugin-template/android/src/main/kotlin/__JAVA_PATH__.kt.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import android.util.Log

class {{ CLASS }} {

fun echo(value: String?): String? {
Log.i("Echo", value ?: "null")
fun echo(value: String): String {
Log.i("Echo", value)

return value
}
Expand Down
2 changes: 1 addition & 1 deletion assets/plugin-template/android/src/main/kotlin/__JAVA_PATH__Plugin.kt.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class {{ CLASS }}Plugin : Plugin() {

@PluginMethod
fun echo(call: PluginCall) {
val value = call.getString("value")
val value = call.getString("value") ?: ""

val ret = JSObject().apply {
put("value", implementation.echo(value))
Expand Down