fix: Do not init git if inside git repo#144
Merged
OS-pedrogustavobilro merged 2 commits intomainfrom Mar 2, 2026
Merged
Conversation
alexgerardojacinto
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
I was hitting this issue several times recently, and got annoyed so fixed it. Before trying to run
git init, we run another git command with--is-inside-work-treeto check if the plugin directory is already in a git repo (e.g. this can be the case for monorepos)It can be argued that this isn't an issue, but imo it's more often than not, you don't want to create a git repo inside another git repo. Users can still run git init afterwards if they choose, but this package shouldn't make that decision for them.