feat: Option to Select Language (Kotlin or Java) for Android Plugins#122
Conversation
Since it's the recommended for Capacitor 8 References: https://capacitorjs.com/docs/updating/plugins/8-0#update-to-java-21-recommended
And also support deleting them if the opposite language is selected.
To make it clearer that there are only two options.
Otherwise --android-lang is ignored and user needs to prompt it specifically
Rather than using kotlin only if "kotlin" is returned
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Hey @fabiomartino, thanks for the PR! Apologies for the time it took to take a look at it. I did some minor fixes and improvements that I noticed but overall it looks good, tested here and it's all working fine.
For reference: Most of the tests I did are available at https://github.com/OS-pedrogustavobilro/test-create-capacitor-plugin-pr122
Hi @OS-pedrogustavobilro, thank you for the review and for the feedback! I've also opened a related proposal here (#141) which I think could be a valuable addition to the project. Looking forward to your thoughts! |
|
@fabiomartino merging this PR. As for #141, from a quick look I gave it makes sense, but we'll take a closer look and provide feedback there. Thanks again! |
Title:
(feat) Add Option to Select Programming Language (Kotlin or Java) for Android Plugins
Description:
This pull request introduces the ability to select the programming language (Kotlin or Java) when working with Android plugins.
Key Changes:
Kotlin Templates:
Dependency Management:
build.gradlefile.Enhanced Development Workflow:
Changelog:
build.gradle) to include Kotlin dependencies when Kotlin is selected.Notes:
build.gradleinclude standard configurations required for compatibility with Android projects.Let me know if you need further edits or details!