fix(cli): reject apksigner for Android App Bundles - #8568
Open
Boulea7 wants to merge 1 commit into
Open
Conversation
Boulea7
marked this pull request as ready for review
August 11, 2026 16:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reject Android App Bundle builds configured with
apksignerbefore Gradle or signing commands run. The CLI keepsjarsigneras its default and uses the same resolved signing tool for validation and dispatch.Change Type
Rationale / Problems Fixed
apksigneronly supports APK files. Passing an AAB to it currently produces a misleadingMinSdkVersionException/ missing manifest error after the bundle has been built. The new validation explains how to selectjarsigneror build an APK instead.Fixes #8428
Tests or Reproductions
npm test -- --runTestsByPath test/build.android.spec.ts(5 tests passed)npm test --workspace @capacitor/cli(89 tests passed)npm run build --workspace @capacitor/clinpm run lintThe regression tests cover the rejected AAB/apksigner combination and the valid default AAB, explicit AAB/jarsigner, APK/apksigner, and APK/jarsigner paths. External commands are mocked at the
runCommandprocess boundary. A real Android SDK and keystore signing run was not performed.Screenshots / Media
Not applicable.
Platforms Affected
Notes / Comments
SwiftLint was skipped by
node-swiftlintbecause validation ran on Linux; the TypeScript and formatting portions of the official lint command passed.