fix(cli): resolve Nx hooks from package directories - #8566
Open
fzlzjerry wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #8538.
Hook lookup now checks the package at the directory passed to
runPlatformHookbefore considering the Nx workspace root. This lets an app and each plugin run the hook declared in their ownpackage.jsonand with their own working directory.The Nx-root behavior is retained as a fallback for integrated workspaces where the app has no local package or hook. Plugin lookups explicitly disable that fallback so a workspace-root hook is not run once for every installed plugin.
Regression tests cover:
Testing
npm test --workspace @capacitor/cli(13 suites, 87 tests)npm run build --workspace @capacitor/clinpm run eslint(0 errors; 7 warnings in unchanged tests)npm run prettier -- --check