Skip to content

chore: add dist to root gitignore#2560

Merged
OS-pedrogustavobilro merged 1 commit into
mainfrom
chore/dist-root-gitignore
Jul 3, 2026
Merged

chore: add dist to root gitignore#2560
OS-pedrogustavobilro merged 1 commit into
mainfrom
chore/dist-root-gitignore

Conversation

@OS-pedrogustavobilro

Copy link
Copy Markdown
Contributor

Plugins already have dist inside their own .gitignore, this is to prevent dist files appearing untracked after switching to a branch that doesn't have a certain plugin. A current example:

  1. Have the camera plugin in main branch with build dist folder.
  2. Switch to next branch where camera was removed
  3. Without this PR, you'll find camera folder in untracked files, because of the dist folder that wasn't in source control therefore it was never technically removed.

With dist in root .gitignore we won't accidentally commit those files.

@OS-pedrogustavobilro OS-pedrogustavobilro requested review from a team and OS-ruimoreiramendes and removed request for a team July 3, 2026 13:00

@jcesarmobile jcesarmobile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run build in the root no longer builds camera plugin, you have to explicitly build the plugin from the folder, which nobody should be doing anymore since it was moved to another repository, but anyway, we can merge this

@OS-pedrogustavobilro

Copy link
Copy Markdown
Contributor Author

npm run build in the root no longer builds camera plugin, you have to explicitly build the plugin from the folder, which nobody should be doing anymore since it was moved to another repository, but anyway, we can merge this

The reason why this happens for me then is because I have built it before that was disabled. Which may happen again in the future if we start moving other plugins out of this repository.

@OS-pedrogustavobilro OS-pedrogustavobilro merged commit 060e41c into main Jul 3, 2026
9 checks passed
@OS-pedrogustavobilro OS-pedrogustavobilro deleted the chore/dist-root-gitignore branch July 3, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants