fix(action-sheet): correct some cancelable misbehaviors#2491
fix(action-sheet): correct some cancelable misbehaviors#2491jcesarmobile merged 3 commits intomainfrom
Conversation
|
Released dev build of action-sheet with dev version: 8.1.1-dev-2491-20260312T121343.0 |
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Tested with the dev build on the testapp PR, all's working well on Android iOS and Web.
Thank you for looking into this and making the fixes!
I left a comment, that maybe is more subjective, but I'll approve the PR nonetheless.
action-sheet/src/definitions.ts
Outdated
| * Not available on iOS 26+ or if there is a button with ActionSheetButtonStyle.Cancel, | ||
| * in those cases, the Action Sheet is always cancelable by clicking outside of it. |
There was a problem hiding this comment.
Minor: While ActionSheetButtonStyle only applies for iOS, when it was said "if there is a button with ActionSheetButtonStyle.Cancel" it started to give me a wrong impression that it applied to other platforms as well
I'm thinking of something like
* On iOS, it is not available if there is a button with ActionSheetButtonStyle.Cancel, or if device is on iOS 26+.
* In those cases, the Action Sheet is always cancelable by clicking outside of it.
Maybe this is a subjective matter, but let me know what you think.
There was a problem hiding this comment.
yeah, at first I put it in separate lines and then, since both related to iOS and style is iOS only, I put it together and removed iOS from the second part.
But it's true that could be confusing since people might have not read that style is iOS only.
Changed it.
Android was not returning
canceled: falsewhen not canceled.Web was not setting a default false value, passing undefined to PWA elements, which caused issues on the first presentation.
iOS was not behaving as documented when there was a Cancel button and it can support the
cancelableoption on iOS 18 and older if there is no Cancel button.Also, added a few changes in the definition docs.