Skip to content

fix(action-sheet): correct some cancelable misbehaviors#2491

Merged
jcesarmobile merged 3 commits intomainfrom
fix-actiosheet
Mar 12, 2026
Merged

fix(action-sheet): correct some cancelable misbehaviors#2491
jcesarmobile merged 3 commits intomainfrom
fix-actiosheet

Conversation

@jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Mar 11, 2026

Android was not returning canceled: false when not canceled.
Web was not setting a default false value, passing undefined to PWA elements, which caused issues on the first presentation.
iOS was not behaving as documented when there was a Cancel button and it can support the cancelable option on iOS 18 and older if there is no Cancel button.

Also, added a few changes in the definition docs.

@github-actions
Copy link

github-actions bot commented Mar 11, 2026

Released dev build of action-sheet with dev version: 8.1.1-dev-2491-20260312T121343.0

@OS-pedrogustavobilro OS-pedrogustavobilro self-assigned this Mar 12, 2026
Copy link
Contributor

@OS-pedrogustavobilro OS-pedrogustavobilro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the dev build on the testapp PR, all's working well on Android iOS and Web.

Thank you for looking into this and making the fixes!

I left a comment, that maybe is more subjective, but I'll approve the PR nonetheless.

Comment on lines +28 to +29
* Not available on iOS 26+ or if there is a button with ActionSheetButtonStyle.Cancel,
* in those cases, the Action Sheet is always cancelable by clicking outside of it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: While ActionSheetButtonStyle only applies for iOS, when it was said "if there is a button with ActionSheetButtonStyle.Cancel" it started to give me a wrong impression that it applied to other platforms as well

I'm thinking of something like

   * On iOS, it is not available if there is a button with ActionSheetButtonStyle.Cancel, or if device is on iOS 26+.
   * In those cases, the Action Sheet is always cancelable by clicking outside of it.

Maybe this is a subjective matter, but let me know what you think.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, at first I put it in separate lines and then, since both related to iOS and style is iOS only, I put it together and removed iOS from the second part.
But it's true that could be confusing since people might have not read that style is iOS only.
Changed it.

@jcesarmobile jcesarmobile merged commit f1506be into main Mar 12, 2026
9 checks passed
@jcesarmobile jcesarmobile deleted the fix-actiosheet branch March 12, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants