-
Notifications
You must be signed in to change notification settings - Fork 6
chore: adding organization wide pull request template #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
theproducer
wants to merge
2
commits into
main
Choose a base branch
from
new-pr-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| ## Description | ||
| <!--- Describe your changes in detail --> | ||
|
|
||
| ## Change Type | ||
| - [ ] Fix | ||
| - [ ] Feature | ||
| - [ ] Refactor | ||
| - [ ] Breaking Change | ||
| - [ ] Documentation | ||
|
|
||
| ## Rationale / Problems Fixed | ||
| <!--- Give us more information about why you think this PR is needed, or what problems it fixes --> | ||
| <!--- Be sure to place links to related issues or discussions here --> | ||
|
|
||
| ## Tests or Reproductions | ||
| <!--- Include a link to a minimal test project that can be used to validate the changes --> | ||
| <!--- Alternatively, describe how you tested your changes in detail --> | ||
| <!--- The easier it is to test and validate your pull request, the faster it can be reviewed --> | ||
|
|
||
| ## Screenshots / Media | ||
| <!--- (Optional) Include screenshots, videos or other files relevant to the pull request --> | ||
|
|
||
| ## Versions Affected | ||
| - [ ] 7.x | ||
| - [ ] 8.x | ||
| - [ ] 9.x | ||
|
|
||
| ## Platforms Affected | ||
| - [ ] Android | ||
| - [ ] iOS | ||
| - [ ] Web | ||
OS-pedrogustavobilro marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ## Notes / Comments | ||
| <!--- Put anything else here that would be good for us to know! --> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment to #7 (comment)
But also, in most scenarios, community members will open PRs to
main. Will people know to fill this field? Maybe if they got a bug in a specific version?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...yeah, im seeing this more as where the contributor intends for the PR to go. We can decide where it ultimately goes.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, either 1. the contributor knows which branch contains his specific version (in this example
7.x,mainornext), and open it there or 2. he opens it tomainbut checks which version(s) is the PR relevant for?The name "Versions Affected" make it seem like it's something else. If it's a fix, it can make sense. If it's a feature, not as much?