Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Remove deprecated flutter pub run note#377

Closed
abraham wants to merge 1 commit intoinvertase:mainfrom
abraham:patch-1
Closed

Remove deprecated flutter pub run note#377
abraham wants to merge 1 commit intoinvertase:mainfrom
abraham:patch-1

Conversation

@abraham
Copy link
Copy Markdown

@abraham abraham commented Jan 2, 2026

Running flutter pub run custom_lint results in a deprecation notice.

flutter pub run custom_lint
Deprecated. Use `dart run` instead.
Analyzing...                           0.0s

No issues found!

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 2, 2026

@abraham is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

@docs-page
Copy link
Copy Markdown

docs-page Bot commented Jan 2, 2026

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/dart_custom_lint~377

Documentation is deployed and generated using docs.page.

@tsavo-at-pieces
Copy link
Copy Markdown

Code Quality Review

Changes

Removes two lines from README.md that recommended running flutter pub run custom_lint for Flutter projects. The flutter pub run command is deprecated in favor of dart run, which already works for both Dart and Flutter projects and is documented immediately above the removed lines.

Quality Assessment

Positives:

  • Correct removal. flutter pub run has been deprecated since Flutter 3.12+ / Dart 3.1+ and emits a deprecation warning as shown in the PR description.
  • dart run custom_lint works universally for both Dart-only and Flutter projects, so the Flutter-specific instruction was redundant even before the deprecation.
  • Minimal, surgical change -- exactly the right scope for a docs fix.
  • No trailing whitespace or formatting issues introduced.

No concerns. This is a straightforward documentation correction.

Verdict

APPROVE -- Clean, correct removal of deprecated guidance. The remaining dart run custom_lint instruction covers both Dart and Flutter projects.

@tsavo-at-pieces
Copy link
Copy Markdown

Fork Maintainer Review (dart_custom_lint)

Reviewing on behalf of open-runtime/dart_custom_lint fork.

Summary

Removes the deprecated flutter pub run custom_lint instruction from the README. The flutter pub run command has been deprecated in favor of dart run, and using it produces a deprecation warning. The PR removes the two-line note: "If you are working on a Flutter project, run flutter pub run custom_lint instead."

Upstream Status

Open on upstream (invertase/dart_custom_lint), not yet merged. Community contribution by @abraham.

Assessment

Trivially correct. flutter pub run has been deprecated since Flutter 3.12+ / Dart 3.1+. The existing dart run custom_lint instruction already works for both Dart and Flutter projects. Removing the outdated guidance prevents user confusion.

  • 0 additions, 2 deletions (README.md only)
  • No code changes
  • No risk

Recommendation

SYNC_FROM_UPSTREAM (once merged) -- This is a documentation-only change with zero risk. Will come in naturally when we sync from upstream. Not worth cherry-picking independently given how minor it is.

@tsavo-at-pieces
Copy link
Copy Markdown

Compatibility Review (Monorepo Impact)

Reviewer context: We maintain the open-runtime/dart_custom_lint fork, consumed as a workspace member in our Dart monorepo (aot_monorepo).

Monorepo Impact

NONE. This is a README-only change (removes 2 lines). No code, no dependencies, no configuration affected. Our monorepo uses dart run custom_lint exclusively; we do not use flutter pub run.

Dependency Concerns

None. Documentation-only change.

Recommendation

MERGE -- Clean removal of deprecated guidance. dart run custom_lint works for both Dart and Flutter projects. No monorepo compatibility concerns whatsoever.

@abraham abraham closed this Mar 12, 2026
@abraham abraham deleted the patch-1 branch March 12, 2026 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants