[refactor] Attachment images#11961
Open
SchrodingersGat wants to merge 20 commits into
Open
Conversation
- is_image - thumbnail
- Don't need is_image field - Can introspect from the thumbnail
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (92.70%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #11961 +/- ##
==========================================
- Coverage 91.44% 91.31% -0.14%
==========================================
Files 974 969 -5
Lines 50704 50074 -630
==========================================
- Hits 46366 45724 -642
- Misses 4338 4350 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
matmair
approved these changes
May 18, 2026
Member
matmair
left a comment
There was a problem hiding this comment.
LGTM overall; if we want to change attachments meaningfully in 1.4.0 I would have some larger points worth adressing
…ree into attachment-images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds / refactors some functionality related to attachments
Changes
Rationale
This forms the first part of a re-think of how we might approach generic images against any model instance - see #10484
However, none of that will be implemented here - this is a low-scope change to allow discrimination of attachments which are also images, and display them as such in the UI
Tasks
Future Work (Potentially, TBD)
django-stdimageand migrate todjango-picture#11647