Skip to content

Comments

Add tests#37

Merged
jonathan-taylor merged 17 commits intomainfrom
add_tests
Feb 3, 2026
Merged

Add tests#37
jonathan-taylor merged 17 commits intomainfrom
add_tests

Conversation

@jonathan-taylor
Copy link
Collaborator

@jonathan-taylor jonathan-taylor commented Feb 3, 2026

Title: build: Switch to setuptools_scm, add tests, and update docs

Description:

This PR includes several updates to the build system, testing, and documentation.

  • Build:

    • The versioning has been switched from versioneer to setuptools_scm. This removes the vendored _version.py file and simplifies the packaging configuration in pyproject.toml.

  • Fixes:

    • The _calc_score function in ISLP/models/generic_selector.py has been updated to use the params argument instead of fit_params to align with the latest scikit-learn API.
    • In ISLP/survival.py, .x.item() is now used to extract the scalar value from the root finding result.

  • Testing:

    • New tests have been added for the cluster, pygam, and svm modules to improve code coverage and ensure correctness.

  • Documentation:

    • The installation guide in docs/source/installation.myst has been updated to include instructions for using uv as an alternative to conda for environment management.
    • The ISLP_labs submodule has been updated to the latest commit.

@jonathan-taylor
loosening numpy and pandas versions
e4657bf
@jonathan-taylor
fixes to build requirements
a5d54b3
@jonathan-taylor
simplifying setup.py, logic in pyproject.toml
273a727
@jonathan-taylor
fixing _estimator_type flags
4281ada
@jonathan-taylor
feat: Add scikit-learn estimator type tags
4d9f028 
Adds the `__sklearn_tags__` method to the `sklearn_sm` and `sklearn_selected` wrappers. This allows scikit-learn to correctly identify the estimator type (regressor or classifier) based on the statsmodels model.

This change enables the use of scikit-learn's cross-validation and model selection tools with these wrappers.

Tests have been added to verify that OLS and GLM Binomial models are correctly identified.
@jonathan-taylor
removing redundant setup.py
2beabce
@jonathan-taylor
unused pkg_resources import
bcd8598
@jonathan-taylor
ensure we get a 0-dim answer; use arg params for cross_val_score
1624cb0
@jonathan-taylor
adding some new tests
e569d8e
@jonathan-taylor
updating version
10981f2
@jonathan-taylor
ISLP_labs at v2.2.1
9ecacdb
@jonathan-taylor
update versioneer
e00048e
@jonathan-taylor
using setuptools_scm
d79747c
@jonathan-taylor
update install instructions
62e5866
@jonathan-taylor
adding fit_params as kwargs
63b8f73
@jonathan-taylor jonathan-taylor mentioned this pull request Feb 3, 2026
Merged
@jonathan-taylor jonathan-taylor merged commit bf1816e into main Feb 3, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonathan-taylor