[netrid] Fix misbehaviour tests by not using too large area for Unauthenticated / Incorrectly authenticated requests#1396
Conversation
…henticated / Incorrectly authenticated requests
00635b1 to
423bff9
Compare
BenjaminPelletier
left a comment
There was a problem hiding this comment.
Hypothetically, the unauthenticated coverage could extend to queries expected to elicit errors like 413 for too large of a diagonal when authenticated. For instance, a USS could have a bug that properly 401s in most cases, but 413s even when unauthenticated. In that case, these queries might have served as the authenticated side of the unauthenticated-with-too-large-diagonal case. But, we don't actually perform the unauthenticated-with-too-large-diagonal case so we definitely shouldn't perform the authenticated side. And, I don't know that we would want to spend the necessary queries to achieve that particular coverage -- automated testing coverage is far, far cheaper than manual testing, but it's not free (for the users running it, in addition to dev+maintenance time) so we do need to keep an eye on our value/cost. So, I think this PR is appropriate :)
This PR follow #1388
It does fix the strange behavior of 'misbehaviour' tests, that tried first with an invalid area to retrive flights to be tested for Unauthenticated / Incorrectly authenticated requests.
Notice invalid area queries are still tested in the 'Invalid search area' test.
Before:
After: