[tooling]: Enforce in CI generation of gen.go files

[the-glu]

This PR follows #1455

It does enforce that *.gen.go files have been generated and don't change.

Minor side fix on docker run command, that set -it for no reason and that make it failing in ci. Changed to --rm because locally it's building up useless containers quickly.

[mickmis]

LGTM modulo comment

[mickmis]

Sounds like this belongs to repository hygiene. Also put the script in the makefile, and delete the hashfiles?

[the-glu]

I wanted to avoid having it in the Makefile, because it's going to generate the files, and therefor change the state of the repo/files with a check. Is it really ok to do so?

(And locally / in the Makefile, running the check will fix it, so that not really a check ^^')

[mickmis]

Well, if there is a change, we are a in a dirty state and should fail. BTW we could make that explicit by not using hashes but checking if there is any local change (e.g. git diff --exit-code).
So what about doing:

make apis
git diff --exit-code

[mickmis]

And also move it to repo hygiene (i.e. a step in hygiene-tests)

[the-glu]

I did it but

• It will check more than generated files
• It may be influenced by previous steps generating some change for some reasons

so I don't think that the "correctest" approach.

[mickmis]

True that.
But actually as a whole I'd expect the previous steps to not pollute the local repo. Checking that nothing has changed at the end could be a feature IMO :) Should be a bit more explicit though.

What about:

• Out of explicitness, in this step only check for generated files: git diff --exit-code -- '*.gen.go'
• Add a separate step with just git diff --exit-code that checks that no other previous step has changed anything previously

[the-glu]

Seems better yes, I changed it slightly:

1. Check that generated files didn't change (dues to linting)
2. Make apis
3. Check that generated files didn't change (if that fail here, it's api)
4. Check that files didn't change in another steps

What do you think?

[mickmis]

Yep great, thanks