Adding zpm "ci" command to install from a lock file#1080
Adding zpm "ci" command to install from a lock file#1080isc-jlechtne wants to merge 6 commits intomainfrom
Conversation
isc-jlechtne
requested review from
isc-cborbonm,
isc-dchui,
isc-egabhart,
isc-eneil,
isc-jili,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
isc-dchui
left a comment
isc-dchui
left a comment
There was a problem hiding this comment.
Good overall! Just a few small things. Also you'll want to add a description.
| } | ||
| continue | ||
| } | ||
| elseif (verbose) { |
There was a problem hiding this comment.
Nit: change to one line like } elseif (verbose) {
| } elseif (tCommandInfo = "history") { | ||
| do ..History(.tCommandInfo) | ||
| } elseif (tCommandInfo = "ci") { | ||
| do ..CleanInstall(.tCommandInfo) |
There was a problem hiding this comment.
It's a bit confusing to me to have "ci" stand for "CleanInstall", since 1) CI=continuous integration, and 2) it doesn't mention the lock file like "LockFileInstall" would for example.
But taking a step back, what's the benefit of having a new command versus using a flag on install/load?
|
|
||
| ### Added | ||
| - #1024: Added flag -export-python-deps to publish command | ||
| - #962: Adding zpm "ci" command to install from a lock file |
There was a problem hiding this comment.
You'll need to pull from main and move this entry to 0.10.7
| set moduleName = $get(commandInfo("parameters","module")) | ||
| set version = $get(commandInfo("parameters","version")) | ||
| set verbose = $get(commandInfo("data","Verbose")) | ||
| set log = ##class(%IPM.General.HistoryTemp).CleanInstallInit(moduleName) |
There was a problem hiding this comment.
Also add a test to check that the history log is being populated correctly (see Test.PM.Integration.History)
| set verbose = $get(commandInfo("data","Verbose")) | ||
| set log = ##class(%IPM.General.HistoryTemp).CleanInstallInit(moduleName) | ||
|
|
||
| // TODO: Add "path"? (see Update() for more info of calling install v load) |
There was a problem hiding this comment.
When is this todo being done or removed?
2 participants
No description provided.