feat: implement recursive placeholder resolution in Default parameters#1013
Open
AshokThangavel wants to merge 16 commits intointersystems:mainfrom
Open
feat: implement recursive placeholder resolution in Default parameters#1013AshokThangavel wants to merge 16 commits intointersystems:mainfrom
AshokThangavel wants to merge 16 commits intointersystems:mainfrom
Conversation
AshokThangavel
requested review from
isc-dchui,
isc-egabhart,
isc-eneil,
isc-jili,
isc-jlechtne,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
isc-dchui
requested changes
Jan 20, 2026
Collaborator
isc-dchui
left a comment
isc-dchui
left a comment
There was a problem hiding this comment.
A few comments and questions
-Support nested ${var} and {$var} delimiters and handled Frankenstein-case
isc-dchui
reviewed
Jan 23, 2026
Collaborator
isc-dchui
left a comment
isc-dchui
left a comment
There was a problem hiding this comment.
Thanks for the updates! Here's another pass of comments/questions
…xpression - Adopted %EvaluateSystemExpression for system variable resolution to align with existing APIs. - Retained multi-pass logic to handle nested and "Frankenstein" placeholders. - Implemented a priority gate: customParams take precedence over system defaults. - Hardened maxLevels condition using an explicit guard clause for better robustness.
isc-dchui
reviewed
Feb 2, 2026
Collaborator
isc-dchui
left a comment
isc-dchui
left a comment
There was a problem hiding this comment.
Just a few more things, thanks!
Collaborator
|
This needs a pull from main and an update for the changelog entry to 0.10.7 and then we're good to go. |
Contributor
Author
|
I’ve pulled the latest changes from main and resolved the conflicts in CHANGELOG.md. The new entry has been updated to |
isc-dchui
previously approved these changes
Mar 9, 2026
isc-dchui
previously approved these changes
Mar 9, 2026
…com/AshokThangavel/ipm into feat/unified-variable-interpolation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Recursive Placeholder Resolution in Module Parameter
Description
This PR introduces deeply nested variables or chained configuration settings where one
${variable}depends on another.with a safety handle complex dependencies and prevent infinite loops in the case of circular references.
fixes: #1009
Changes
ResolvePlaceholdersto use awhileloop that continues as long as substitutions are being made.Testing Performed
${A}->${B}->${C}->FinalValue.Test.PM.Integration.Modulethat:module.xmlfrom XData.loadcommand to verify the full lifecycle of the variable resolution.Test Execution Results:
Test.PM.Integration.Module