Add to source control no longer fails for non-host PTD items#968
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
=======================================
Coverage 49.10% 49.10%
=======================================
Files 23 23
Lines 3287 3291 +4
=======================================
+ Hits 1614 1616 +2
- Misses 1673 1675 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isc-egabhart
approved these changes
May 12, 2026
isc-dchui
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #965
When exporting .PTD documents we were assuming they were always decomposed production items following our naming standard. Now we add a check on the internal name. Non-host PTD items fall back to our generic logic for custom studio documents, so they will be exported with file extension .PTD.
Testing
Unit test covers adding to source control and naming logic.
Checklist
mainbranch rebased or merged.git-webui/srchave matching changes ingit-webui/release)