Skip to content

Add to source control no longer fails for non-host PTD items#968

Merged
isc-pbarton merged 1 commit into
mainfrom
fix-non-host-ptds
May 12, 2026
Merged

Add to source control no longer fails for non-host PTD items#968
isc-pbarton merged 1 commit into
mainfrom
fix-non-host-ptds

Conversation

@isc-pbarton
Copy link
Copy Markdown
Collaborator

Description

Resolves #965
When exporting .PTD documents we were assuming they were always decomposed production items following our naming standard. Now we add a check on the internal name. Non-host PTD items fall back to our generic logic for custom studio documents, so they will be exported with file extension .PTD.

Testing

Unit test covers adding to source control and naming logic.

Checklist

  • This branch has the latest changes from the main branch rebased or merged.
  • Web UI has been built (any changes in git-webui/src have matching changes in git-webui/release)
  • CHANGELOG.md entry added if appropriate.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.10%. Comparing base (c0d7b72) to head (dfe8e8d).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #968   +/-   ##
=======================================
  Coverage   49.10%   49.10%           
=======================================
  Files          23       23           
  Lines        3287     3291    +4     
=======================================
+ Hits         1614     1616    +2     
- Misses       1673     1675    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isc-pbarton isc-pbarton merged commit 47d1b1e into main May 12, 2026
2 checks passed
@isc-pbarton isc-pbarton deleted the fix-non-host-ptds branch May 12, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not handling Project Text Documents that are not production/host settings.

4 participants