Validate that SSH key file path is not a directory#966
Open
isc-pbarton wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #966 +/- ##
=======================================
Coverage 49.10% 49.10%
=======================================
Files 23 23
Lines 3287 3287
=======================================
Hits 1614 1614
Misses 1673 1673 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isc-dchui
reviewed
May 11, 2026
|
|
||
| <server> | ||
| if (settings.privateKeyFile '= "") && fileExists { | ||
| if (settings.privateKeyFile '= "") && fileExists && '$$$ISERR(validateSC) { |
Collaborator
There was a problem hiding this comment.
What's wrong with $$$ISOK()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #943
Adds validation to confirm the SSH key file path is not a directory when configuring Embedded Git, both through the Configure() prompt and the Settings page.
Testing
In the development container:
do ##class(SourceControl.Git.API).Configure()to go through the configuration prompts. When prompted for ssh key file path, put in/usr/irissys/mgr: the Configure prompt displays an informative error and quits out at the end. Try again with/usr/irissys/mgr/test_key.pub: at the end it prompts you to create the SSH key, and successfully does so.