Skip to content

Port changes from ISC internal source control hooks#950

Open
isc-pbarton wants to merge 5 commits intomainfrom
reconcile-production
Open

Port changes from ISC internal source control hooks#950
isc-pbarton wants to merge 5 commits intomainfrom
reconcile-production

Conversation

@isc-pbarton
Copy link
Collaborator

Resolves #949

Two functional changes are the ones noted in the changelog. Also includes utilities to update production hosts after a deploy, but these are not yet used in Embedded Git.

@isc-pbarton isc-pbarton marked this pull request as draft March 18, 2026 14:17
@isc-pbarton

This comment was marked as outdated.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 11.18421% with 135 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.18%. Comparing base (299b7b8) to head (58247d0).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Production.cls 10.59% 135 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
- Coverage   50.98%   49.18%   -1.80%     
==========================================
  Files          23       23              
  Lines        3138     3269     +131     
==========================================
+ Hits         1600     1608       +8     
- Misses       1538     1661     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isc-pbarton isc-pbarton marked this pull request as ready for review March 18, 2026 16:06
Copy link
Collaborator

@isc-dchui isc-dchui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny thing


/// Imports a PTD into a production given an external name and produciton name
ClassMethod ImportPTD(externalName As %String, productionName As %String) As %Status
/// Imports a PTD into a produciton given an external name and production name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: "produciton" (I like how you fixed one typo and then reintroduced it elsewhere)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port changes from %Studio.SourceControl.Production

4 participants