Fix adding and committing percent routines#946
Merged
isc-pbarton merged 4 commits intomainfrom Mar 17, 2026
Merged
Conversation
…d to not be in %SYS also includes some utilities to run unit tests in docker from command line.
…y RefreshUncommitted
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #946 +/- ##
=======================================
Coverage 50.98% 50.98%
=======================================
Files 23 23
Lines 3138 3138
=======================================
Hits 1600 1600
Misses 1538 1538 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isc-dchui
reviewed
Mar 17, 2026
Collaborator
isc-dchui
left a comment
There was a problem hiding this comment.
Looks good, just one thing
isc-dchui
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #944
Manual testing in the container: