Skip to content

Fix adding and committing percent routines#946

Merged
isc-pbarton merged 4 commits intomainfrom
fix-percent-routines
Mar 17, 2026
Merged

Fix adding and committing percent routines#946
isc-pbarton merged 4 commits intomainfrom
fix-percent-routines

Conversation

@isc-pbarton
Copy link
Collaborator

Fixes #944

Manual testing in the container:

  • initialize git repo with ##class(SourceControl.Git.API).Configure()
  • Add a routine mapping in the USER namespace of %pbarton* to USER database
  • From Git Web UI, export the VS Code workspace and open in VS Code
  • Add a new routine %pbartontest.mac and save
  • Check source control menus. It should have options to remove and commit. Test removing and then adding to Git, then committing. View git history to confirm it was committed

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.98%. Comparing base (f16c376) to head (a3d2b26).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage   50.98%   50.98%           
=======================================
  Files          23       23           
  Lines        3138     3138           
=======================================
  Hits         1600     1600           
  Misses       1538     1538           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@isc-dchui isc-dchui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one thing

@isc-pbarton isc-pbarton merged commit 60c7acf into main Mar 17, 2026
2 checks passed
@isc-pbarton isc-pbarton deleted the fix-percent-routines branch March 17, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Server Source Control dropdown does not show "commit" option for INT/MAC routines starting with "%", but works through web UI

3 participants