Fix password disclosure via serverForUri and stale cookie reuse after logout/401 - #1824
Open
isc-klu wants to merge 11 commits into
Open
Fix password disclosure via serverForUri and stale cookie reuse after logout/401#1824isc-klu wants to merge 11 commits into
isc-klu wants to merge 11 commits into
Conversation
isc-klu
changed the title
isc-klu
marked this pull request as ready for review
August 13, 2026 14:59
gjsjohnmurray
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1825 and #1823.
#1825 — serverForUri now clears the Authorization object before returning it, so it only carries a resolved password when one is set in plaintext in settings.json. AtelierAPI.config now clones the Authorization object before returning it, so callers invoking
.resolve()/.clear()on the returned object can no longer mutate the shared, internal one.#1823 — logoutOfSessions and the 401 handler in AtelierAPI.request() now delete the corresponding cookiesMap entry, so a stale/invalidated cookie can't keep being resent on subsequent requests.
Also included: a display-string fix for the connection URL shown when connecting a folder to a server namespace — it had an extra
/hardcoded before pathPrefix, which produced a doubled slash since pathPrefix already includes its own leading/.