Skip to content

[-]:fix/patch stack overflow vulnerability #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaaaaavier merged 3 commits into from
Apr 1, 2026
Merged

[-]:fix/patch stack overflow vulnerability #1871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c16440c
fix: pin yaml 1.x to 1.10.3 to patch stack overflow vulnerability
jaaaaavier Apr 1, 2026
e35a7f6
Update TrustedSection.tsx
jaaaaavier Apr 1, 2026
bbe2139
remove driffle
jaaaaavier Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,11 +212,6 @@ module.exports = {
destination: '/redeem/stackcommerce',
permanent: false,
},
{
source: '/driffle',
destination: '/redeem/driffle',
permanent: false,
},
{
source: '/special-offer/:filename',
destination: '/specialoffer/:filename',
Expand Down
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Copy link
Copy Markdown
Collaborator

@xabg2 xabg2 Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about upgrading the package versions instead of adding them to resolutions? Can we do that or there is no new version for these packages that can fix that?

Copy link
Copy Markdown
Contributor Author

@jaaaaavier jaaaaavier Apr 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been checking and upgrading isn't viable here @emotion/react, @emotion/styled, and react-select are already on their latest versions, no newer release that drops the yaml@1.x dependency. @svgr/webpack could be bumped from v6 to v8, but that's a major version with breaking changes, i prefer not doing for now.

Copy link
Copy Markdown
Collaborator

@xabg2 xabg2 Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect then

Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@
},
"resolutions": {
"**/js-yaml": "^4.1.1",
"@emotion/react/**/yaml": "1.10.3",
"@emotion/styled/**/yaml": "1.10.3",
"@svgr/webpack/**/yaml": "1.10.3",
"react-select/**/yaml": "1.10.3",
"nyc": "^17.1.0",
"form-data": "^4.0.4",
"tar": "^7.5.7",
Expand Down
2 changes: 1 addition & 1 deletion src/components/auth/SignUp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { signup } from '@/lib/auth';
interface SignUpProps {
textContent: any;
loading?: boolean;
provider?: 'STACKCOMMERCE' | 'TECHCULT' | 'DEALMIRROR' | 'MIGHTYDEALS' | 'OYSTERVPN' | 'COINGATE' | 'DRIFFLE';
provider?: 'STACKCOMMERCE' | 'TECHCULT' | 'DEALMIRROR' | 'MIGHTYDEALS' | 'OYSTERVPN' | 'COINGATE' ;
}

export default function SignUp(props: Readonly<SignUpProps>) {
Expand Down
6 changes: 3 additions & 3 deletions src/components/home/TrustedSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default function TrustedSection({
return (
<section
ref={sectionRef}
className={`flex h-full w-full flex-col items-start justify-start overflow-hidden px-8 py-10 lg:h-min lg:items-center lg:justify-center lg:gap-20 lg:pb-28 ${
className={`flex h-full w-full flex-col items-start justify-start overflow-hidden px-8 py-10 lg:h-min lg:items-center lg:justify-center lg:gap-20 lg:pb-28 lg:px-10 xl:px-32 3xl:px-80 ${
darkMode ? 'bg-[#1C1C1C]' : ''
}`}
style={
Expand All @@ -73,7 +73,7 @@ export default function TrustedSection({
{bottomBar && (
<div className="absolute bottom-0 left-8 right-8 h-[1px] bg-neutral-35 lg:bottom-0 lg:left-32 lg:right-32"></div>
)}
<p className="flex w-[1280px] flex-wrap font-semibold text-[60px] leading-[100%] py-1 gap-x-[0.35em]">
<p className="w-full font-semibold text-[60px] leading-[100%] py-1 text-justify">
{groups.map((group, i) => (
<span
key={i}
Expand All @@ -85,7 +85,7 @@ export default function TrustedSection({
transition: 'color 0.4s ease',
}}
>
{group}
{i > 0 ? ' ' : ''}{group}
</span>
))}
</p>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/redeem/[filename].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ interface RedeemPageProps {
lang: string;
}

const ALLOWED_PATHS = ['stackcommerce', 'coingate', 'driffle'];
const ALLOWED_PATHS = ['stackcommerce', 'coingate'];

const SpecialOfferPage = ({
metatagsDescriptions,
Expand All @@ -48,7 +48,7 @@ const SpecialOfferPage = ({
setOpenDialog(true);
};

const ALLOWED_PROVIDERS = ['STACKCOMMERCE', 'COINGATE', 'DRIFFLE'] as const;
const ALLOWED_PROVIDERS = ['STACKCOMMERCE', 'COINGATE'] as const;

type Provider = typeof ALLOWED_PROVIDERS[number];

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9420,10 +9420,10 @@ yallist@^5.0.0:
resolved "https://registry.yarnpkg.com/yallist/-/yallist-5.0.0.tgz#00e2de443639ed0d78fd87de0d27469fbcffb533"
integrity sha512-YgvUTfwqyc7UXVMrB+SImsVYSmTS8X/tSrtdNZMImM+n7+QTriRXyXim0mBrTXNeqzVF0KWGgHPeiyViFFrNDw==

yaml@^1.10.0:
version "1.10.2"
resolved "https://registry.yarnpkg.com/yaml/-/yaml-1.10.2.tgz#2301c5ffbf12b467de8da2333a459e29e7920e4b"
integrity sha512-r3vXyErRCYJ7wg28yvBY5VSoAF8ZvlcW9/BwUzEtUsjvX/DKs24dIkuwjtuprwJJHsbyUbLApepYTR1BN4uHrg==
yaml@1.10.3, yaml@^1.10.0:
version "1.10.3"
resolved "https://registry.yarnpkg.com/yaml/-/yaml-1.10.3.tgz#76e407ed95c42684fb8e14641e5de62fe65bbcb3"
integrity sha512-vIYeF1u3CjlhAFekPPAk2h/Kv4T3mAkMox5OymRiJQB0spDP10LHvt+K7G9Ny6NuuMAb25/6n1qyUjAcGNf/AA==

yaml@^2.3.4:
version "2.5.0"
Expand Down
Loading