[PB-3528]:feat/update coverage for components#94
Merged
jaaaaavier merged 3 commits intomasterfrom Apr 1, 2026
Merged
Conversation
larryrider
reviewed
Mar 31, 2026
| expect(avatarComponent).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| it('Avatar with single word name should render correctly', () => { |
Contributor
There was a problem hiding this comment.
hey, the "it" tests are made to build the descriptions like "it should do whatever when whatever", for this other tests its more readable if you just use the "test" word, or if you just change it to this "it" descriptions
Contributor
Author
There was a problem hiding this comment.
Got it, I'll update this test now. I can also do a pass on the rest of the tests to apply this convention consistently. I'll reference task PB-3528 for that. What do you think??
larryrider
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a much larger PR aimed at improving coverage across all components that cause "issues" when running the yarn test command. I am organizing this into several smaller PRs to avoid creating one massive pull request.