[PB-3520]:feat/Popover component update#93
Merged
jaaaaavier merged 2 commits intomasterfrom Apr 1, 2026
Merged
Conversation
larryrider
reviewed
Mar 30, 2026
src/components/popover/Popover.tsx
Outdated
| 'absolute z-50 transform rounded-md border border-gray-10 ' + | ||
| `${direction === 'up' ? 'bottom-full mb-1' : 'mt-1'} ` + | ||
| `${align === 'left' ? 'right-0' : 'left-0'} ` + | ||
| `${direction === 'up' ? (align === 'left' ? 'origin-bottom-right' : 'origin-bottom-left') : (align === 'left' ? 'origin-top-right' : 'origin-top-left')} ` + |
Contributor
There was a problem hiding this comment.
hey, maybe we could add an object map so its more readable, wdyt?
im thinking in something like this:
const originMap = {
up: { left: 'origin-bottom-right', right: 'origin-bottom-left' },
down: { left: 'origin-top-right', right: 'origin-top-left' },
};
// usage
`${originMap[direction][align]}`
larryrider
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces changes for the Popover component, we updated the behaviour of the align property, previously. it was aligning inversily. We also added the direction property that helps to display the popover up or down the component