Open
Conversation
|
AlexisMora
reviewed
Mar 30, 2026
Comment on lines
+19
to
+43
| export function convertToReadableStream(readStream: Readable): ReadableStream<Uint8Array> { | ||
| return new ReadableStream<Uint8Array>({ | ||
| start(controller) { | ||
| readStream.on('data', (chunk) => { | ||
| // Convertir el chunk a Uint8Array y pasarlo al controller | ||
| controller.enqueue(new Uint8Array(chunk)); | ||
| }); | ||
|
|
||
| readStream.on('end', () => { | ||
| // Señalar que la transmisión ha finalizado | ||
| controller.close(); | ||
| }); | ||
|
|
||
| readStream.on('error', (err) => { | ||
| // Señalar un error al controller | ||
| controller.error(err); | ||
| }); | ||
| }, | ||
| cancel() { | ||
| // Abortar la lectura del ReadStream de fs | ||
| readStream.destroy(); | ||
| }, | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
These comments could be in english or deleted if you think they are not necessary
Comment on lines
+115
to
+132
| const excludeNodeIds: string = excludeNodes.join(','); | ||
| const path = `${networkApiUrl}/buckets/${bucketId}/files/${fileId}`; | ||
| const queryParams = `?limit=${limit}&skip=${skip}&exclude=${excludeNodeIds}`; | ||
|
|
||
| const defaultOpts: AxiosRequestConfig = { | ||
| responseType: 'json', | ||
| url: path + queryParams, | ||
| }; | ||
|
|
||
| return axios | ||
| .request<Mirror[]>({ ...defaultOpts, ...opts }) | ||
| .then((res) => { | ||
| return res.data; | ||
| }) | ||
| .catch((err) => { | ||
| throw err; | ||
| }); | ||
| } |
There was a problem hiding this comment.
We could add a todo to move this to the proper driveServerClient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added