Add subscriptions with open payments blog article#223
Open
adrianboros wants to merge 4 commits intomainfrom
Open
Add subscriptions with open payments blog article#223adrianboros wants to merge 4 commits intomainfrom
adrianboros wants to merge 4 commits intomainfrom
Conversation
✅ Deploy Preview for interledger-org-developers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
@adrianboros please optimise your images by running them through https://tinypng.com/ |
Contributor
|
The post reads as if it's geared more towards academia. I suggest that the style be changed to make it more accessible for a general audience. Also, since OP implements GNAP for authorization, we should mention and reference it in the body of the post. |
mkurapov
reviewed
Apr 30, 2026
Contributor
mkurapov
left a comment
mkurapov
left a comment
There was a problem hiding this comment.
Added some comments. I also agree with Mohammed about the tone, and I think we could trim this down a bit by having it slightly more high level.
It could also be nice to point to the code/PR where this was implemented in case others wanted to get an idea for a subscription service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Fixes #123)bun run formatto ensure code is properly formattedbun run lintpasses without errorsSummary