Skip to content

fix: pass user attributes during loginUserWithUserAttributes on Android #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imSzukala wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: pass user attributes during loginUserWithUserAttributes on Android #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
072f8b6
fix: pass user attributes during loginUserWithUserAttributes on Android
imSzukala Mar 10, 2026
17c989f
fix: simplify loginUserWithUserAttributes type to UserAttributes
imSzukala Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions android/src/newarch/IntercomModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ public void loginUserWithUserAttributes(ReadableMap params, Promise promise) {
promise.reject(IntercomErrorCodes.IDENTIFIED_REGISTRATION, "Invalid userId or email");
}
if (registration != null) {
UserAttributes userAttributes = IntercomHelpers.buildUserAttributes(params);
registration.withUserAttributes(userAttributes);

Intercom.client().loginIdentifiedUser(registration, new IntercomStatusCallback() {
@Override
public void onSuccess() {
Expand Down
3 changes: 3 additions & 0 deletions android/src/oldarch/IntercomModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ public void loginUserWithUserAttributes(ReadableMap params, Promise promise) {
promise.reject(IntercomErrorCodes.IDENTIFIED_REGISTRATION, "Invalid userId or email");
}
if (registration != null) {
UserAttributes userAttributes = IntercomHelpers.buildUserAttributes(params);
registration.withUserAttributes(userAttributes);

Intercom.client().loginIdentifiedUser(registration, new IntercomStatusCallback() {
@Override
public void onSuccess() {
Expand Down
4 changes: 1 addition & 3 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,7 @@ export type IntercomType = {
* Valid identifiers are `userId` and `email` which must be set in the {@link UserAttributes} object.
* @param params The {@link UserAttributes} object that contains the user's `email` or `userId`.
*/
loginUserWithUserAttributes: (
params: Pick<UserAttributes, 'email' | 'userId'>
) => Promise<boolean>;
loginUserWithUserAttributes: (params: UserAttributes) => Promise<boolean>;

/**
* Log a user out of their Intercom session.
Expand Down
Loading