Restructure skills based on review: fix React bug, replace search with customer-360#3
Open
levindixon wants to merge 8 commits intomainfrom
Open
Restructure skills based on review: fix React bug, replace search with customer-360#3levindixon wants to merge 8 commits intomainfrom
levindixon wants to merge 8 commits intomainfrom
Conversation
Provides architecture overview, skill documentation, key conventions (security-first defaults, progressive disclosure, read-only access), and development workflow for this declarative plugin. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The React @intercom/messenger-js-sdk examples omitted api_base from both the authenticated and anonymous Intercom() calls. Next.js and Vue.js examples already included it. Without api_base, EU and AU customers silently hit the wrong data center — requests succeed but return no data. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This skill was a thin wrapper around MCP tool calls that Claude can already perform natively. Its trigger phrases overlapped with intercom-insights, causing ambiguous skill activation. Useful UX patterns (table formatting, follow-up suggestions, empty-result recovery) have been folded into the intercom-analysis skill. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Restructure the skill to lead with workflows rather than API docs: - Rename directory from intercom-insights/ to intercom-analysis/ - Rewrite SKILL.md: remove tool documentation (~40 lines), keep workflow steps verbatim, add defined output artifacts for both pattern analysis and issue investigation, add troubleshooting section - Incorporate salvaged UX patterns from intercom-search (table formatting, follow-up suggestions, empty-result recovery) into Best Practices - Add Tool Selection Guide, Conversation Search Strategies, and Contact Lookup Strategies to references/mcp-tools.md where the content belongs This follows the progressive disclosure pattern: SKILL.md focuses on what to do (workflows), mcp-tools.md covers how (API details), loaded only when needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Three changes to the install-messenger skill: - Update frontmatter: add license field, rewrite description to lead with outcomes rather than trigger phrases - Add placeholder substitution instruction after Requirements section so generated code uses real values, not YOUR_WORKSPACE_ID placeholders - Add Troubleshooting section covering the five most common setup failures: missing JWT library, wrong secret, plan limitations, clock skew on exp, and CORS errors on the JWT endpoint Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add a new customer-360 skill that produces comprehensive customer profiles by aggregating contact data, conversation history, and interaction timelines from Intercom. This replaces the removed intercom-search as the third skill, providing a genuine workflow rather than a thin search wrapper. Update README.md and CLAUDE.md to reflect the new skill composition: - Replace intercom-search with customer-360 in skills tables - Rename intercom-insights to intercom-analysis - Update usage examples - Reframe Limitations as Access & Limitations, leading with read-only safety as a feature Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4edd6f0 to
895ff12
Compare
normprovost
reviewed
Feb 25, 2026
| .then(res => res.json()) | ||
| .then(({ token }) => { | ||
| Intercom({ | ||
| api_base: 'https://api-iam.intercom.io', |
Contributor
There was a problem hiding this comment.
api_base is optional and most times should not be included. lets leave it out. but we should do a review of installation methods from the install page to make sure we get them all https://app.intercom.com/a/apps/_/settings/channels/messenger/install
The official Intercom install page omits api_base since it defaults to US. Updated all boot examples to match, and reframed the Regional Data Centers section to clarify api_base is only needed for EU or Australia. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds Angular, Ember, Django, PHP, and third-party integration coverage to match what users see on the Intercom Messenger install page. Also adds intercom-rails gem note as a simpler Rails alternative. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
A technical review evaluated this plugin against Anthropic's skill-building guide and Sentry's exemplar plugin. It found that two of three skills were closer to "MCP documentation wrappers" than workflow automation, the React SDK example had a silent bug breaking EU/AU customers, and trigger phrases overlapped between skills. This PR implements the P0–P2 recommendations.
How?
Fixed the React
api_baseomission, removed the redundantintercom-searchskill, restructuredintercom-insights→intercom-analysisto lead with workflows instead of API docs (moving tool reference toreferences/mcp-tools.md), added troubleshooting toinstall-messenger, and introduced a newcustomer-360skill that produces comprehensive customer profiles — a genuine workflow replacing the thin search wrapper.Generated with Claude Code