Support bracket-style OpenAPI 3 query params#472
Merged
Conversation
2691703 to
12ff45a
Compare
geemus
approved these changes
Apr 12, 2026
Member
geemus
left a comment
There was a problem hiding this comment.
Oops, sorry for the delay. I saw the draft, but missed it when you marked it ready for review.
lgtm
Member
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #327
This fixes OpenAPI 3 request validation for query parameters declared with bracket notation, for example:
Rack parses a request like
?filter[slug]=/testinto a nested hash:Before this change, Committee validated against the literal parameter name only, so the request was rejected as:
This change normalizes Rack-style nested query hashes into bracket notation before OpenAPI 3 parameter validation/deserialization when the schema expects bracket-style names.