[DeviceSanitizer] Move sanitizer predicates to new SanitizerUtils.h - #22915
Open
wenju-he wants to merge 1 commit into
Open
[DeviceSanitizer] Move sanitizer predicates to new SanitizerUtils.h#22915wenju-he wants to merge 1 commit into
wenju-he wants to merge 1 commit into
Conversation
This is follow-up of review comment intel#22901 (comment) isModuleUsingAsan/Msan/Tsan are sanitizer-specific, not generic SYCL utilities, so move them out of SYCLLowerIR/SYCLUtils.{h,cpp} into a new SanitizerUtils.{h,cpp}. Also add ASAN/MSAN/TSAN_KERNEL_METADATA_PREFIX constants there so the "__{Asan,Msan,Tsan}KernelMetadata" prefix strings have a single definition instead of being duplicated as literals across SanitizerPostOptimizer.cpp, SanitizerPostSplitProcessing.cpp, and clang's OffloadBundler.cpp. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sarnex
approved these changes
Aug 11, 2026
| #include "llvm/IR/Module.h" | ||
|
|
||
| namespace llvm { | ||
| namespace sycl { |
Contributor
There was a problem hiding this comment.
nit: should we change the namespace?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is follow-up of review comment
#22901 (comment)
isModuleUsingAsan/Msan/Tsan are sanitizer-specific, not generic SYCL utilities, so move them out of SYCLLowerIR/SYCLUtils.{h,cpp} into a new SanitizerUtils.{h,cpp}. Also add ASAN/MSAN/TSAN_KERNEL_METADATA_PREFIX constants there so the "__{Asan,Msan,Tsan}KernelMetadata" prefix strings have a single definition instead of being duplicated as literals across SanitizerPostOptimizer.cpp, SanitizerPostSplitProcessing.cpp, and clang's OffloadBundler.cpp.