[SYCL] Align item with SYCL 2020 - #22907
Open
crystarm wants to merge 2 commits into
Open
Conversation
crystarm
force-pushed
the
item-noexcept-hidden-friends
branch
from
August 10, 2026 13:41
b2f7306 to
8ddab7b
Compare
crystarm
marked this pull request as ready for review
August 10, 2026 13:42
Contributor
Author
|
The original change applied noexcept to the equality operators as well as to the item query and conversion API. However, equality is specified by the common by-value interface in Table 10, where the hidden-friend declarations do not carry noexcept. This follow-up keeps the hidden-friend implementation, drops the additional public exception guarantee, and strengthens the test against accidental member operators. |
KornevNikita
approved these changes
Aug 10, 2026
KornevNikita
left a comment
KornevNikita
left a comment
Contributor
There was a problem hiding this comment.
LGTM. @crystarm please update the description
Contributor
|
@sergey-semenov could you take a look please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22870.
Align
sycl::itemwith the SYCL 2020 specification:noexceptto theitemquery and conversion functions.noexcepttooperator==andoperator!=.