[SYCL] Don't release sub-devices on Linux OpenCL either - #22897
Open
wenju-he wants to merge 1 commit into
Open
Conversation
Releasing temporary sub-device handles at the end of device_impl::create_sub_devices (introduced in 8456b01, "[SYCL] Fix memory leak for sub-devices (intel#20370)") can crash during late shutdown: shutdown_late() releases the platform's cached device_impls after the OpenCL ICD may have already begun tearing down, so clReleaseDevice() fails and trips assert(Res == CL_SUCCESS) in the opencl adapter's ur_device_handle_t_ destructor, aborting the process. bdfa20b worked around this for Windows OpenCL only. Extend the same workaround to the OpenCL backend regardless of OS, and update DeviceRefCounter unit test accordingly. Fixes: SYCL :: PlatformDeviceIndex/sycl_ext_oneapi_platform_device_index.cpp CMPLRLLVM-77426 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing temporary sub-device handles at the end of device_impl::create_sub_devices (introduced in 8456b01, "[SYCL] Fix memory leak for sub-devices (#20370)") can crash during late shutdown: shutdown_late() releases the platform's cached device_impls after the OpenCL ICD may have already begun tearing down, so clReleaseDevice() fails and trips assert(Res == CL_SUCCESS) in the opencl adapter's ur_device_handle_t_ destructor, aborting the process.
bdfa20b worked around this for Windows OpenCL only. Extend the same workaround to the OpenCL backend regardless of OS, and update DeviceRefCounter unit test accordingly.
Fixes: SYCL :: PlatformDeviceIndex/sycl_ext_oneapi_platform_device_index.cpp
CMPLRLLVM-77426