[SPIR-V] Reapply llvm-spirv lifetime intrinsic customizations - #22862
Draft
vmaksimo wants to merge 1 commit into
Draft
[SPIR-V] Reapply llvm-spirv lifetime intrinsic customizations#22862vmaksimo wants to merge 1 commit into
vmaksimo wants to merge 1 commit into
Conversation
Restores the bitcast of private-AS lifetime pointer operands to i8*, so that OpLifetimeStart/OpLifetimeStop carry the object size rather than 0. Removing this made ocloc AOT compilation fail with an IGC segmentation violation and error -11 on drivers whose SPIR-V reader consumes the Size operand. The same failure signature was reported for PyTorch builds on sycl-rel-7_0, where the customization is already restored (intel#22325). Reverts commit 4f9fa54 (intel#22253)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the bitcast of private-AS lifetime pointer operands to i8*, so that OpLifetimeStart/OpLifetimeStop carry the object size rather than 0.
Removing this made ocloc AOT compilation fail with an IGC segmentation violation and error -11 on drivers whose SPIR-V reader consumes the Size operand. The same failure signature was reported for PyTorch builds on sycl-rel-7_0, where the customization is already restored (#22325).
Reverts commit 4f9fa54 (#22253)