Skip to content

[SYCL] Support build with shared libzstd (#22294)#22438

Open
sarnex wants to merge 1 commit into
intel:sycl-rel-7_0from
sarnex:cherry6
Open

[SYCL] Support build with shared libzstd (#22294)#22438
sarnex wants to merge 1 commit into
intel:sycl-rel-7_0from
sarnex:cherry6

Conversation

@sarnex

@sarnex sarnex commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Cherry pick of 2594da5

Distros of Fedora family package only shared libzstd build against which was not fully supported. This commit addresses the gap in a similar way as it's already handled in few other cases in llvm. See for reference:

if(LLVM_ENABLE_ZSTD)
if(TARGET zstd::libzstd_shared AND NOT LLVM_USE_STATIC_ZSTD)
set(zstd_target zstd::libzstd_shared)
else()
set(zstd_target zstd::libzstd_static)
endif()
endif()
if(LLVM_ENABLE_ZSTD)
list(APPEND imported_libs ${zstd_target})
endif()

and:

if(LLVM_ENABLE_ZSTD)
if(TARGET zstd::libzstd_shared AND NOT LLVM_USE_STATIC_ZSTD)
set(zstd_target zstd::libzstd_shared)
else()
set(zstd_target zstd::libzstd_static)
endif()
endif()
if(LLVM_ENABLE_ZSTD)
list(APPEND imported_libs ${zstd_target})

Fixes: #22310

CC: @sarnex

Distros of Fedora family package only shared libzstd build against which
was not fully supported. This commit addresses the gap in a similar way
as it's already handled in few other cases in llvm. See for reference:

https://github.com/intel/llvm/blob/b09acde14f87bb417d5868905a684263beb32991/llvm/lib/Support/CMakeLists.txt#L28-L38

and:

https://github.com/intel/llvm/blob/b09acde14f87bb417d5868905a684263beb32991/lld/ELF/CMakeLists.txt#L9-L18

Fixes: intel#22310

CC: @sarnex

Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
@sarnex sarnex temporarily deployed to WindowsCILock June 25, 2026 15:05 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock June 25, 2026 16:03 — with GitHub Actions Inactive
@sarnex sarnex marked this pull request as ready for review June 25, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants