[SYCL] Implement sycl_ext_oneapi_fp4 extension#22437
Open
dm-vodopyanov wants to merge 2 commits into
Open
Conversation
| significand = static_cast<uint64_t>(frac); | ||
| uint64_t tmp = significand; | ||
| leadingBit = -1; | ||
| while (tmp != 0u) { |
Contributor
There was a problem hiding this comment.
Nit: I do not like this loop but it is necessary evil. There are alternatives:
- Use C++20 feature
std::bit_widthwhich is not an option because we need to support C++17, as I understand - Compiler intrinsics. It has drawback since GCC/clang intrinsic name(
__builtin_clz) is not equal to MSVC(__lzcnt) one.
I am just curious if option 2 faster than this loop.
@dm-vodopyanov Do you think we can try to use №2 if it is faster?
| : static_cast<ToT>(narrowed)); | ||
| return static_cast<ToT>(narrowed); | ||
| } else { | ||
| (void)R; |
Contributor
There was a problem hiding this comment.
Nit: the alternative is [[maybe_unused]] which can reduce the number of lines.
| #endif | ||
| } | ||
|
|
||
| static constexpr void CheckConstraints(rounding r) { |
Contributor
There was a problem hiding this comment.
Please, mark it with [[maybe_unused]]. Otherwise, build with --no-assertions will fail.
dklochkov-emb
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifications: