[SYCL] Fix skipped check for device_global property in SYCLPostLink#22402
Open
maksimsab wants to merge 3 commits into
Open
[SYCL] Fix skipped check for device_global property in SYCLPostLink#22402maksimsab wants to merge 3 commits into
maksimsab wants to merge 3 commits into
Conversation
This check used to be skipped in the release compilation mode because IR dumping is turned off there. fixes: CMPLRLLVM-74325
cperkinsintel
approved these changes
Jun 23, 2026
Contributor
Author
|
From the log: Doesn't look related. |
Contributor
Author
|
@intel/llvm-gatekeepers Could we, please, merge that? |
sarnex
reviewed
Jun 24, 2026
| continue; | ||
|
|
||
| auto *ST = dyn_cast<StructType>(GV.getValueType()); | ||
| if (!ST || ST->isLiteral()) // Literal structs don't have names. |
Contributor
There was a problem hiding this comment.
instead would calling hasName() work? just in case there is another case there is no name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check used to be skipped in the release compilation mode because IR dumping is turned off there.
fixes: CMPLRLLVM-74325