[NFC] Remove accidentally commited ccache folder#22393
Conversation
|
|
||
| #pulldown temp folder | ||
| /spirv-patches-* | ||
| /ccache-sycl |
There was a problem hiding this comment.
Why do you need this? Can you put ccache files/directory to one of existing directories?
For example, this file already has a rule for:
.cache/build*
There was a problem hiding this comment.
Sure, I can change other scripts to move the ccache, but I think it would be easier and safer to add it here. This won't cause additional issue given we have other customizations like !buidbot above.
There was a problem hiding this comment.
If we need to add a new rule for local ccache directory, I suggest following standard naming scheme:
| /ccache-sycl | |
| /.ccache/ # e.g. .ccache/sycl/, .ccache/main/, etc. |
|
@jsji, hi, do you have a plan to address the feedback from Alexey above and merge the fix? |
@dm-vodopyanov, @jsji is OOO this week. I'm okay to address the comment later, but someone need to fix CI before merging this PR. |
Folder was added accidentally in conflict resolution. Added the folder to .gitignore as well.