[SYCL] Fix bug in enqueue free functions implementation#21461
Merged
sarnex merged 31 commits intointel:syclfrom Mar 9, 2026
Merged
[SYCL] Fix bug in enqueue free functions implementation#21461sarnex merged 31 commits intointel:syclfrom
sarnex merged 31 commits intointel:syclfrom
Conversation
lbushi25
changed the title
lbushi25
commented
Mar 6, 2026
| [[maybe_unused]] kernel_function_s<Func> KernelFunc, | ||
| ArgsT &&...Args) { | ||
| detail::submit_kernel_direct_parallel_for( | ||
| std::move(Q), Range, [Args...](sycl::nd_item<>) { Func(Args...); }); |
Contributor
Author
There was a problem hiding this comment.
The bug is in this line. I had forgotten to pass the Dimensions template parameter to sycl::nd_item<> and so it always defaults to sycl::nd_item<1> which makes it impossible to work with 2 or 3 dimensional kernels.
slawekptak
approved these changes
Mar 9, 2026
Contributor
Author
|
@intel/llvm-gatekeepers Can we get this merged please? The failures are both of which are unrelated to the changes of this PR which only touches a single E2E test in a completely separate directory. |
KornevNikita
pushed a commit
that referenced
this pull request
Mar 25, 2026
There is a bug in some of the enqueue free functions that causes them to work only with 1-dimensional kernels. This PR fixes this bug and adds a couple of test cases to test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in some of the enqueue free functions that causes them to work only with 1-dimensional kernels. This PR fixes this bug and adds a couple of test cases to test it.